Thread (235 messages) flat view 235 messages, 5 authors, 2021-09-02

Re: [PATCH v2 07/24] midx: clear auxiliary .rev after replacing the MIDX

From: Jeff King <hidden>
Date: 2021-07-21 11:27:30

On Mon, Jun 21, 2021 at 06:25:15PM -0400, Taylor Blau wrote:
When writing a new multi-pack index, write_midx_internal() attempts to
clean up any auxiliary files (currently just the MIDX's `.rev` file, but
soon to include a `.bitmap`, too) corresponding to the MIDX it's
replacing.

This step should happen after the new MIDX is written into place, since
doing so beforehand means that the old MIDX could be read without its
corresponding .rev file.
Good catch. The patch looks obviously correct.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help