Re: [PATCH 10/23] fsmonitor--daemon: add pathname classification

On 4/26/2021 4:11 PM, Eric Sunshine wrote:

On Mon, Apr 26, 2021 at 3:17 PM Derrick Stolee [off-list ref] wrote:

quoted

On 4/1/2021 11:40 AM, Jeff Hostetler via GitGitGadget wrote:

quoted

+#define FSMONITOR_COOKIE_PREFIX ".fsmonitor-daemon-"
+
+     if (!fspathncmp(rel, FSMONITOR_COOKIE_PREFIX,
+                     strlen(FSMONITOR_COOKIE_PREFIX)))

Seems like this strlen() could be abstracted out. Is it
something the compiler can compute and set for us? Or,
should we create a macro for this constant?

If you're asking whether the compiler will resolve strlen("literal
string") to an integer constant at compile time rather than computing
the length at runtime, then the answer is that on this project we
presume that the compiler is smart enough to do that.

That is what I was asking.

Or are you asking for a function something like this?

    fspathhasprefix(rel, FSMONITOR_COOKIE_PREFIX)

The "fix" I would recommend otherwise would be

	if (!fspathncmp(rel, FSMONITOR_COOKIE_PREFIX,
			FSMONITOR_COOKIE_PREFIX_LEN))

which is much uglier. I'm glad we can trust the compiler to
be smart enough.

Thanks,
-Stolee