Thread (181 messages) 181 messages, 7 authors, 2021-01-20

Re: [PATCH v2 09/11] archive tests: use a cheaper "zipinfo -h" invocation to get header

From: Jeff King <hidden>
Date: 2021-01-17 17:09:01

On Sat, Jan 16, 2021 at 04:35:52PM +0100, Ævar Arnfjörð Bjarmason wrote:
Change an invocation of zipinfo added in 19ee29401d (t5004: test ZIP
archives with many entries, 2015-08-22) to simply ask zipinfo for the
header info, rather than spewing out info about the entire archive and
race to kill it with SIGPIPE due to the downstream "head -2".

I ran across this because I'm adding a "set -o pipefail" test
mode. This won't be needed for the version of the mode that I'm
introducing (which currently relies on a patch to GNU bash), but I
think this is a good idea anyway.
Makes sense. The only risk here would be that "-h" is not portable. But
I don't have any reason to think that's the case, and since it's just a
test, I'm fine with proceeding and seeing if anybody screams.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help