Re: [PATCH v2 06/11] git-svn tests: rewrite brittle tests to use "--[no-]merges".
From: Jeff King <hidden>
Date: 2021-01-17 16:49:02
From: Jeff King <hidden>
Date: 2021-01-17 16:49:02
On Sat, Jan 16, 2021 at 04:35:49PM +0100, Ævar Arnfjörð Bjarmason wrote:
From: Jeff King <redacted> Rewrite a brittle tests which used "rev-list" without "--[no-]merges" to figure out if a set of commits turned into merge commits or not. Signed-off-by: Jeff King <redacted> Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> Commit-message-by: Ævar Arnfjörð Bjarmason [off-list ref]
Thanks for picking this up. I think it's a cleanup worth doing. I didn't actually sign-off the original I sent, though. I'm quite happy to do so now, and in general everything I send to the list as a "something like this" patch will be done with the intent that it could be contributed under the DCO. But I think in such a case, we should stop short of forging the signoff. And ideally get an explicit signoff, or lacking that just add your own to assert DCO's paragraph (b). Anyway, this is most definitely: Signed-off-by: Jeff King [off-list ref] -Peff