Thread (181 messages) 181 messages, 7 authors, 2021-01-20

Re: [PATCH 1/6] test-lib: add tests for test_might_fail

From: Jeff King <hidden>
Date: 2021-01-15 09:37:05

On Fri, Jan 15, 2021 at 12:35:10AM +0100, Ævar Arnfjörð Bjarmason wrote:
+test_expect_success 'test_might_fail is like test_must_fail ok=' '
+	! test_must_fail git version &&
+	! test_must_fail ok= git version &&
+	test_might_fail git version
+'
The title confuses me. Isn't might_fail like "must_fail ok=success"?

And certainly the code here shows us expecting the _opposite_ of what
"Must_fail ok=" does.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help