Thread (181 messages) 181 messages, 7 authors, 2021-01-20

Re: [PATCH 01/27] lib-bash.sh: move `then` onto its own line

From: Eric Sunshine <hidden>
Date: 2019-11-15 18:22:24 

On Thu, Nov 14, 2019 at 8:00 PM Denton Liu [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The code style for tests is to have statements on their own line if
possible. Move the `then` onto its own line so that it conforms with the
test style.

Signed-off-by: Denton Liu <redacted>
---
diff --git a/t/lib-bash.sh b/t/lib-bash.sh
@@ -2,7 +2,8 @@
-if test -n "$BASH" && test -z "$POSIXLY_CORRECT"; then
+if test -n "$BASH" && test -z "$POSIXLY_CORRECT"
+then
Okay...

        # we are in full-on bash mode
        true
 elif type bash >/dev/null 2>&1; then
... but why not move this 'then' to its own line, as well?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help