On Thu, Apr 30, 2020 at 11:24 PM Emily Shaffer [off-list ref] wrote:

On Mon, Apr 27, 2020 at 08:13:29PM +0000, Han-Wen Nienhuys via GitGitGadget wrote:

quoted

This prepares for supporting the reftable format, which will want
create its own file system layout in .git

Signed-off-by: Han-Wen Nienhuys <redacted>
---
 builtin/init-db.c    | 2 --
 refs/files-backend.c | 6 ++++++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/builtin/init-db.c b/builtin/init-db.c
index 0b7222e7188..3b50b1aa0e5 100644
--- a/builtin/init-db.c
+++ b/builtin/init-db.c

@@ -251,8 +251,6 @@ static int create_default_files(const char *template_path,
       * We need to create a "refs" dir in any case so that older
       * versions of git can tell that this is a repository.
       */
-     safe_create_dir(git_path("refs"), 1);
-     adjust_shared_perm(git_path("refs"));

Is the reftable completely replacing the refs/ dir? Or is the idea that
the refs/ dir is only used by the files backend? The commit message
makes it sound like it's an additional format to support, so I'm a
little confused. Why does the other currently-existing backend not need
the refs/ dir at this stage?

I've dropped this patch from the series; it probably was from before
the compat hack that is described in

  https://git.eclipse.org/r/#/c/157167/

for further clarification: reftable doesn't used the refs/ dir at all,
but we still want to not confuse older git versions.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado