Re: [PATCH v2 5/5] Reftable support for git-core
From: Han-Wen Nienhuys <hidden>
Date: 2020-01-29 18:41:06
On Wed, Jan 29, 2020 at 5:49 PM Martin Fick [off-list ref] wrote:
quoted
If you're actually doing the correct locking and packed-refs read (which "real" implementations like libgit2 do) then no, I don't think that's dangerous. And I think libgit2 properly complains when it sees a repositoryformatversion above 0. I don't know offhand about JGit, or any of the lesser-used ones like dulwich or go-git.Today, some of these sound like shortcuts that are very likely taken quite a bit by cleanup and other maintenance scripts (not necessarily formal git tools), and the impact of these shortcuts is likely low with the current model. However, I suspect these tools/scripts could be seriously disruptive if we leave the refs dir around when using reftable,
Maybe we can leave the refs dir, but have no heads/ directory inside, and make the whole thing read-only? -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado