Thread (295 messages) 295 messages, 13 authors, 2020-07-31

Re: [PATCH v2 5/5] Reftable support for git-core

flat view

From: Jeff King <hidden>
Date: 2020-02-04 19:54:03

On Tue, Feb 04, 2020 at 08:06:57PM +0100, Han-Wen Nienhuys wrote:
On Wed, Jan 29, 2020 at 11:47 AM Jeff King [off-list ref] wrote:
quoted
That said, it might make for easier debugging if the reftables file
declares the size it assumes.
If there is a mismatch in size, the reftable will look completely
corrupted data.  I think this will be a bad experience.
Yes, but I think it would take a bunch of other failures to get there.
And it's true of all of the other parts of Git, too; the master switch
is a config setting that says "I'm a sha-256 repository".

That said, I'm not at all opposed to a header in the reftables file
saying "I'm a sha-256 reftable". We shouldn't ever see a mismatch there,
but that's what I meant by "easier debugging".

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help