On Fri, Feb 21, 2020 at 7:40 AM Jonathan Nieder [off-list ref] wrote:

quoted

This adds the reftable library, and hooks it up as a ref backend.

As promised, here's a patch to include the reftable spec in git.git.
Please include this in the next iteration of this patch series (or if
you prefer for it to land separately, that's also fine with me).

I did.

[...]

quoted

 * support SHA256 as version 2 of the format.

I'd prefer if we error out for now when someone tries to use reftable
when the_hash_algo != sha1.  That would buy a bit more time to pin
down the details of version 2 (e.g., should it only add an object
format field, or object format and oid size?).

You have convinced me that we should go with the 4-byte identifier.

How about setting version=2 and extending the header by 4 bytes (which
hold the 4-byte identifier). The footer would also be increased in
size equivalently. There are no further changes.

BTW, could we document that a reftable consisting of just a footer is
a valid table too?

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado