Re: [PATCH v2 15/20] msvc: support building Git using MS Visual C++

[PATCH 00/17] Fix MSVC support, at long last · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-18
[PATCH 01/17] Mark .bat files as requiring CR/LF endings · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-18
[PATCH 05/17] mingw: replace mingw_startup() hack · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-18
[PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-18
Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant · Eric Sunshine <hidden> · 2019-06-18
Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant · Johannes Schindelin <hidden> · 2019-06-19
Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant · Carlo Arenas <hidden> · 2019-06-19
Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant · Johannes Schindelin <hidden> · 2019-06-19
Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant · Carlo Arenas <hidden> · 2019-06-19
Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant · Johannes Schindelin <hidden> · 2019-06-19
[PATCH 02/17] t0001 (mingw): do not expect a specific order of stdout/stderr · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-18
Re: [PATCH 02/17] t0001 (mingw): do not expect a specific order of stdout/stderr · Eric Sunshine <hidden> · 2019-06-18
Re: [PATCH 02/17] t0001 (mingw): do not expect a specific order of stdout/stderr · Johannes Sixt <hidden> · 2019-06-19
Re: [PATCH 02/17] t0001 (mingw): do not expect a specific order of stdout/stderr · Eric Sunshine <hidden> · 2019-06-19
Re: [PATCH 02/17] t0001 (mingw): do not expect a specific order of stdout/stderr · Johannes Schindelin <hidden> · 2019-06-19
Re: [PATCH 02/17] t0001 (mingw): do not expect a specific order of stdout/stderr · Johannes Schindelin <hidden> · 2019-06-19
Re: [PATCH 02/17] t0001 (mingw): do not expect a specific order of stdout/stderr · Johannes Sixt <hidden> · 2019-06-19
Re: [PATCH 02/17] t0001 (mingw): do not expect a specific order of stdout/stderr · Johannes Schindelin <hidden> · 2019-06-19
[PATCH 09/17] msvc: mark a variable as non-const · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-18
[PATCH 10/17] msvc: do not re-declare the timespec struct · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-18
[PATCH 06/17] msvc: fix dependencies of compat/msvc.c · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-18
[PATCH 07/17] msvc: include sigset_t definition · Philip Oakley via GitGitGadget <hidden> · 2019-06-18
[PATCH 08/17] msvc: define O_ACCMODE · Philip Oakley via GitGitGadget <hidden> · 2019-06-18
[PATCH 04/17] obstack: fix compiler warning · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-18
[PATCH 15/17] msvc: do not pretend to support all signals · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-18
Re: [PATCH 15/17] msvc: do not pretend to support all signals · Eric Sunshine <hidden> · 2019-06-19
Re: [PATCH 15/17] msvc: do not pretend to support all signals · Johannes Schindelin <hidden> · 2019-06-19
[PATCH 16/17] msvc: avoid debug assertion windows in Debug Mode · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-18
[PATCH 13/17] msvc: support building Git using MS Visual C++ · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-18
Re: [PATCH 13/17] msvc: support building Git using MS Visual C++ · Carlo Arenas <hidden> · 2019-06-19
Re: [PATCH 13/17] msvc: support building Git using MS Visual C++ · Johannes Schindelin <hidden> · 2019-06-19
Re: [PATCH 13/17] msvc: support building Git using MS Visual C++ · Eric Sunshine <hidden> · 2019-06-19
Re: [PATCH 13/17] msvc: support building Git using MS Visual C++ · Johannes Schindelin <hidden> · 2019-06-19
[PATCH 14/17] msvc: add pragmas for common warnings · Philip Oakley via GitGitGadget <hidden> · 2019-06-18
[PATCH 12/17] msvc: fix detect_msys_tty() · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-18
[PATCH 17/17] msvc: ignore .dll and incremental compile output · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-18
[PATCH 11/17] msvc: define ftello() · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-18
[PATCH v2 00/20] Fix MSVC support, at long last · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 01/20] mingw: fix a typo in the msysGit-specific section · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 02/20] Mark .bat files as requiring CR/LF endings · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 03/20] t0001 (mingw): do not expect a specific order of stdout/stderr · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 07/20] msvc: fix dependencies of compat/msvc.c · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 06/20] mingw: replace mingw_startup() hack · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 05/20] obstack: fix compiler warning · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 09/20] msvc: define O_ACCMODE · Philip Oakley via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 10/20] msvc: mark a variable as non-const · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 12/20] msvc: define ftello() · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 16/20] msvc: add a compile-time flag to allow detailed heap debugging · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 17/20] msvc: add pragmas for common warnings · Philip Oakley via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 15/20] msvc: support building Git using MS Visual C++ · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-19
Re: [PATCH v2 15/20] msvc: support building Git using MS Visual C++ · Johannes Schindelin <hidden> · 2019-06-21
[PATCH v2 19/20] msvc: avoid debug assertion windows in Debug Mode · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 20/20] msvc: ignore .dll and incremental compile output · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 13/20] msvc: fix detect_msys_tty() · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 18/20] msvc: do not pretend to support all signals · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 14/20] msvc: update Makefile to allow for spaces in the compiler path · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 04/20] cache-tree/blame: avoid reusing the DEBUG constant · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 11/20] msvc: do not re-declare the timespec struct · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-19
[PATCH v2 08/20] msvc: include sigset_t definition · Philip Oakley via GitGitGadget <hidden> · 2019-06-19
[PATCH v3 00/20] Fix MSVC support, at long last · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 01/20] mingw: fix a typo in the msysGit-specific section · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 02/20] Mark .bat files as requiring CR/LF endings · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 03/20] t0001 (mingw): do not expect a specific order of stdout/stderr · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 04/20] cache-tree/blame: avoid reusing the DEBUG constant · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 07/20] msvc: fix dependencies of compat/msvc.c · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 11/20] msvc: do not re-declare the timespec struct · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 10/20] msvc: mark a variable as non-const · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 13/20] msvc: fix detect_msys_tty() · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 16/20] msvc: add a compile-time flag to allow detailed heap debugging · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 14/20] msvc: update Makefile to allow for spaces in the compiler path · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 18/20] msvc: do not pretend to support all signals · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 15/20] msvc: support building Git using MS Visual C++ · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 17/20] msvc: add pragmas for common warnings · Philip Oakley via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 19/20] msvc: avoid debug assertion windows in Debug Mode · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 20/20] msvc: ignore .dll and incremental compile output · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 12/20] msvc: define ftello() · Jeff Hostetler via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 09/20] msvc: define O_ACCMODE · Philip Oakley via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 05/20] obstack: fix compiler warning · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 08/20] msvc: include sigset_t definition · Philip Oakley via GitGitGadget <hidden> · 2019-06-25
[PATCH v3 06/20] mingw: replace mingw_startup() hack · Johannes Schindelin via GitGitGadget <hidden> · 2019-06-25

From: Johannes Schindelin <hidden>
Date: 2019-06-21 20:17:29

Hi,

On Wed, 19 Jun 2019, Jeff Hostetler via GitGitGadget wrote:

quoted hunk ↗ jump to hunk

diff --git a/Makefile b/Makefile
index 3cf8cc8ffd..2b66d5a3f3 100644
--- a/Makefile
+++ b/Makefile

@@ -1240,7 +1240,7 @@ endif

 ifdef SANE_TOOL_PATH
 SANE_TOOL_PATH_SQ = $(subst ','\'',$(SANE_TOOL_PATH))
-BROKEN_PATH_FIX = 's|^\# @@BROKEN_PATH_FIX@@$$|git_broken_path_fix "$(SANE_TOOL_PATH_SQ)"|'
+BROKEN_PATH_FIX = 's|^\# @@BROKEN_PATH_FIX@@$$|git_broken_path_fix $(SANE_TOOL_PATH_SQ)|'

Aaargh! I totally managed to mess this split up. This line should *not* be
touched by this patch.

Will fix locally, in preparation for the next iteration.

Sorry,
Dscho

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help