Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant
From: Johannes Schindelin <hidden>
Date: 2019-06-19 11:19:36
From: Johannes Schindelin <hidden>
Date: 2019-06-19 11:19:36
Hi Eric, On Tue, 18 Jun 2019, Eric Sunshine wrote:
On Tue, Jun 18, 2019 at 8:24 AM Jeff Hostetler via GitGitGadget [off-list ref] wrote:quoted
In MSVC, the DEBUG constant is set automatically whenever compiling with debug information. This is clearly not what was intended in cache-tree.c, so let's use a less ambiguous constant there.s/constant/macro name/ would be clearer.
To me, "macro" always sounds as if it referred to executable code, or at least to something that expands to code. I went with s/constant/name/ instead. Thanks, Dscho
quoted
Signed-off-by: Jeff Hostetler <redacted> Signed-off-by: Johannes Schindelin <redacted>