Thread (80 messages) 80 messages, 5 authors, 2019-06-25

Re: [PATCH 13/17] msvc: support building Git using MS Visual C++

From: Carlo Arenas <hidden>
Date: 2019-06-19 00:51:52 

On Tue, Jun 18, 2019 at 5:26 AM Jeff Hostetler via GitGitGadget
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/compat/mingw.c b/compat/mingw.c
index d14d33308d..667285887a 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -2388,6 +2388,12 @@ static void maybe_redirect_std_handles(void)
                                  GENERIC_WRITE, FILE_FLAG_NO_BUFFERING);
 }

+#ifdef _MSC_VER
+#ifdef _DEBUG
why not use DEBUG instead (without the leading underscore), then you
could also drop the -D_DEBUG below

...
+       # BASIC_CLFAGS += -DUSE_MSVC_CRTDBG
typo

Carlo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help