Hi Carlo,

On Wed, 19 Jun 2019, Carlo Arenas wrote:

while those two changes (from DEBUG to DEBUG_$foo) are worth doing in
their own merit, I am more inclined to consider this as orthogonal
since by your own description[1] the right name to use would be _DEBUG
(with a preceding dash) and that would obviously not conflict here.

Well, both `_DEBUG` and `DEBUG` appear to be defined by Visual Studio in
debug mode. So we still need to rename them, and I'd rather rename them
here than in the next patch series (that will (re-)add support to build in
Visual Studio), as I want the command-line MSVC build to also define both
constants.

the only remaining change then would be to drop the -DDEBUG that gets
added to your BASIC_CFLAGS

No, for consistency with Visual Studio, I want to keep defining both
`DEBUG` and `_DEBUG`. It's just easier that way, as I won't have to spend
extra cycles to remember that those two ways to build Git are slightly
different, when they shouldn't be.

Thanks,
Dscho

Carlo
[1] https://docs.microsoft.com/en-us/cpp/build/reference/md-mt-ld-use-run-time-library?view=vs-2019