Re: [PATCH v4 17/21] tests: add t/helper/ to the PATH with --with-dashes
From: Junio C Hamano <hidden>
Date: 2019-01-23 23:39:24
"Johannes Schindelin via GitGitGadget" [off-list ref] writes:
From: Johannes Schindelin <redacted> We really need to be able to find the test helpers... Really. This change was forgotten when we moved the test helpers into t/helper/ Signed-off-by: Johannes Schindelin <redacted> --- t/test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
It is unfortunate that --with-dashes is needed for valgrind and GIT_TEST_INSTALLED. Otherwise I do not see why we care about keeping the option working. Does any or your test matrix entry actually use --with-dashes and rely on it working, or is it just the stuff that implicitly depend on it? Thanks.
quoted hunk ↗ jump to hunk
diff --git a/t/test-lib.sh b/t/test-lib.sh index 9c0ca5effb..c790e98fd2 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh@@ -1227,7 +1227,7 @@ else # normal case, use ../bin-wrappers only unless $with_dashes: GIT_EXEC_PATH=$GIT_BUILD_DIR if test -n "$with_dashes" then - PATH="$GIT_BUILD_DIR:$PATH" + PATH="$GIT_BUILD_DIR:$GIT_BUILD_DIR/t/helper:$PATH" fi fi GIT_TEMPLATE_DIR="$GIT_BUILD_DIR"/templates/blt