Re: [PATCH v2 09/13] git-p4: use `test_atexit` to kill the daemon

Hi Eric,

On Mon, 15 Oct 2018, Eric Sunshine wrote:

On Mon, Oct 15, 2018 at 6:12 AM Johannes Schindelin via GitGitGadget
[off-list ref] wrote:

quoted

This should be more reliable than the current method, and prepares the
test suite for a consistent way to clean up before re-running the tests
with different options.

Signed-off-by: Johannes Schindelin <redacted>
---

diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh

@@ -134,6 +134,7 @@ check_sub_test_lib_test_err () {
+cat >/dev/null <<\DDD
 test_expect_success 'pretend we have a fully passing test suite' "
        run_sub_test_lib_test full-pass '3 passing tests' <<-\\EOF &&
        for i in 1 2 3

@@ -820,6 +821,7 @@ test_expect_success 'tests clean up even on failures' "
        > 1..2
        EOF
 "
+DDD

Is this "DDD" here-doc leftover debugging goop?

Oy, oy, oy. This is definitely a left-over from debugging (as you can
imagine, it is pretty slow to run t0000-init.sh on Windows, and if I add a
test case, the development cycle is much faster with the trick you see
aboive). This left-over even made it into Git for Windows' `master`
branch! (Which is the reason I missed it before contributing v2).

Will fix,
Dscho