Thread (192 messages) 192 messages, 13 authors, 2021-03-26

Re: [PATCH 2/9] ci/lib.sh: encapsulate Travis-specific things

From: Eric Sunshine <hidden>
Date: 2018-09-03 23:45:33 

On Mon, Sep 3, 2018 at 5:10 PM Johannes Schindelin via GitGitGadget
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
The upcoming patches will allow building git.git via VSTS CI, where
variable names and URLs look a bit different than in Travis CI.

Signed-off-by: Johannes Schindelin <redacted>
---
diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
@@ -28,7 +28,8 @@ osx-clang|osx-gcc)
        # Uncomment this if you want to run perf tests:
        # brew install gnu-time
-       brew install git-lfs gettext
+       test -z "$BREW_INSTALL_PACKAGES" ||
+       eval brew install $BREW_INSTALL_PACKAGES
This 'eval' is unnecessary, isn't it?

    brew install $BREW_INSTALL_PACKAGES

should give the same result.
quoted hunk ↗ jump to hunk
        brew link --force gettext
        brew install caskroom/cask/perforce
diff --git a/ci/lib.sh b/ci/lib.sh
@@ -1,5 +1,26 @@
+       BREW_INSTALL_PACKAGES="git-lfs gettext"
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help