Thread (167 messages) 167 messages, 8 authors, 2018-11-09

Re: [GSoC][PATCH v8 14/20] stash: convert create to builtin

From: Johannes Schindelin <hidden>
Date: 2018-11-09 12:27:57

Hi Paul,

On Wed, 26 Sep 2018, Paul-Sebastian Ungureanu wrote:
Sorry for the late reply. I had a lot on my plate for the last couple of
weeks.
I understand. University can be busy times.
quoted
quoted
+
+	git_config(git_diff_basic_config, NULL);
Is this not called in as part of `git_config(git_default_config, NULL);`
in cmd_stash() already?

*clicketyclick*

I guess not. But then, maybe it would make sense to run with
`git_diff_basic_config` from the get go, to avoid having to run
`git_config()` twice.
I am not sure I got it right, but if I did:

Running `git_config` with `git_diff_basic_config` from the
beginning wouldn't be pointless when we would use any other
command than `create`, `push` and `save`? Although it might
confuse the reader a little bit, the stash should run without
problems.
In my mind, this would simplify the code. Which is always easier on the
reader... ;-)

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help