Re: [GSoC][PATCH v8 14/20] stash: convert create to builtin
From: Paul-Sebastian Ungureanu <hidden>
Date: 2018-09-25 22:20:40
From: Paul-Sebastian Ungureanu <hidden>
Date: 2018-09-25 22:20:40
Hi, Sorry for the late reply. I had a lot on my plate for the last couple of weeks.
quoted
+ + git_config(git_diff_basic_config, NULL);Is this not called in as part of `git_config(git_default_config, NULL);` in cmd_stash() already? *clicketyclick* I guess not. But then, maybe it would make sense to run with `git_diff_basic_config` from the get go, to avoid having to run `git_config()` twice.
I am not sure I got it right, but if I did: Running `git_config` with `git_diff_basic_config` from the beginning wouldn't be pointless when we would use any other command than `create`, `push` and `save`? Although it might confuse the reader a little bit, the stash should run without problems. Best, Paul