Re: [GSoC][PATCH v7 13/26] stash: update `git stash show` documentation
From: Thomas Gummerer <hidden>
Date: 2018-08-15 21:08:21
On 08/08, Paul-Sebastian Ungureanu wrote:
Add in documentation about the change of behavior regarding the `--quiet` option, which was introduced in the last commit. (the `--quiet` option does not exit anymore with erorr if it
s/erorr/error/
is given an empty stash as argument)
If we want to keep the change in behaviour here (which I'm not sure about as mentioned in my comment on the previous patch), I think this should be folded into the previous patch. I don't think there's much value in having this as a separate commit, and folding it into the previous commit has the advantage that we can easily see that the new behaviour is documented.
quoted hunk ↗ jump to hunk
Signed-off-by: Paul-Sebastian Ungureanu <redacted> --- Documentation/git-stash.txt | 3 +++ 1 file changed, 3 insertions(+)diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt index e31ea7d30..d60ebdb96 100644 --- a/Documentation/git-stash.txt +++ b/Documentation/git-stash.txt@@ -117,6 +117,9 @@ show [<options>] [<stash>]:: You can use stash.showStat and/or stash.showPatch config variables to change the default behavior. + It accepts any option known to `git diff`, but acts different on
I notice that we are using single quotes for git commands in some places and backticks in other places in this man page. We may want to clean that up at some point. I wouldn't want to do it in this series though, as this is already long enough, and we've had this inconsistency for a while already.
+ `--quiet` option and exit with zero regardless of differences. + pop [--index] [-q|--quiet] [<stash>]:: Remove a single stashed state from the stash list and apply it -- 2.18.0.573.g56500d98f