Thread (167 messages) 167 messages, 8 authors, 2018-11-09

Re: [PATCH v6 3/4] stash: update test cases conform to coding guidelines

From: Johannes Schindelin <hidden>
Date: 2018-06-26 22:08:24

Hi Paul,

On Mon, 25 Jun 2018, Paul-Sebastian Ungureanu wrote:
Removed whitespaces after redirection operators.
That is accurate a description of what the patch does. Let's add the why
(and change the tense to present tense, as is the custom in our commit
messages):

	This adjusts t3903-stash.sh to conform with our coding conventions
	better, by removing whitespace between redirection operators and
	their file names.

The patch does two more things, though: it breaks at least one long line,
and it renames at least two non-descriptive files to the much better name
`expected`. Maybe you want to mention that in the commit message, to?

Thanks,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help