Re: [PATCH v3 07/23] cat-file: start migrating formatting to ref-filter
From: Jeff King <hidden>
Date: 2018-02-15 05:32:50
From: Jeff King <hidden>
Date: 2018-02-15 05:32:50
On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote:
Move mark_atom_in_object_info() from cat-file to ref-filter and start using it in verify_ref_format(). It also means that we start reusing verify_ref_format() in cat-file. Start from simple moving of mark_atom_in_object_info(), it would be removed later by integrating all needed processes into ref-filter logic.
I see where you're going here, but it feels like there's a lot of boilerplate to move this thing whole, when we plan to get rid of it in the long run. After all, we _already_ support most of these placeholders in ref-filter. I'll keep reading... -Peff