[PATCH v3 01/23] ref-filter: get rid of goto
From: Olga Telezhnaya <hidden>
Date: 2018-02-12 08:09:11
Subsystem:
the rest · Maintainer:
Linus Torvalds
Get rid of goto command in ref-filter for better readability. Signed-off-by: Olga Telezhnaia <redacted> Mentored-by: Christian Couder [off-list ref] Mentored by: Jeff King [off-list ref] --- ref-filter.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c
index f9e25aea7a97e..d04295e33448e 100644
--- a/ref-filter.c
+++ b/ref-filter.c@@ -1477,12 +1477,13 @@ static void populate_value(struct ref_array_item *ref) for (i = 0; i < used_atom_cnt; i++) { struct atom_value *v = &ref->value[i]; - if (v->s == NULL) - goto need_obj; + if (v->s == NULL) { + break; + } } - return; + if (used_atom_cnt <= i) + return; - need_obj: buf = get_obj(&ref->objectname, &obj, &size, &eaten); if (!buf) die(_("missing object %s for %s"), --
https://github.com/git/git/pull/452