Re: [PATCH v3 06/23] cat-file: split expand_atom() into 2 functions
From: Jeff King <hidden>
Date: 2018-02-15 05:28:46
From: Jeff King <hidden>
Date: 2018-02-15 05:28:46
On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote:
Split expand_atom() into 2 different functions, mark_atom_in_object_info() prepares variable for further filling, (new) expand_atom() creates resulting string. Need that for further reusing of formatting logic from ref-filter. Both functions will be step-by-step removed by the end of this patch.
Hmm, this is duplicating the list of atoms. One of the reasons for the mark_query flag in the original is to have a single list, so that it can't go out of sync. So I'd hope to see this split go away by the end of the series... -Peff