Re: [PATCH v3 01/23] ref-filter: get rid of goto

[PATCH RFC 01/24] ref-filter: get rid of goto · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 23/24] cat-file: tests for new atoms added · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 18/24] ref-filter: make valid_atom general again · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 10/24] ref-filter: make populate_value global · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 22/24] for-each-ref: tests for new atoms added · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 09/24] cat-file: start use ref_array_item struct · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 19/24] ref-filter: make populate_value internal again · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 03/24] cat-file: split expand_atom into 2 functions · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 04/24] cat-file: reuse struct ref_format · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 24/24] cat-file: update of docs · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 20/24] ref-filter: unifying formatting of cat-file opts · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 13/24] ref-filter: add is_cat flag · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 17/24] cat-file: reuse printing logic from ref-filter · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 16/24] ref-filter: make cat_file_info independent · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 14/24] ref_filter: add is_rest_atom_used function · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 12/24] ref-filter: get rid of expand_atom_into_fields · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 11/24] cat-file: start reusing populate_value · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 02/24] ref-filter: add return value to some functions · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 08/24] ref-filter: reuse parse_ref_filter_atom · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 06/24] cat-file: move struct expand_data into ref-filter · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 21/24] ref-filter: work with objectsize:disk · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 05/24] ref-filter: make valid_atom as function parameter · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 07/24] cat-file: start migrating to ref-filter · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC 15/24] cat-file: move skip_object_info into ref-filter · Olga Telezhnaya <hidden> · 2018-01-26
[PATCH RFC v2 01/25] ref-filter: get rid of goto · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 08/25] ref-filter: reuse parse_ref_filter_atom() · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 05/25] cat-file: move struct expand_data into ref-filter · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 22/25] ref-filter: work with objectsize:disk · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 13/25] ref-filter: get rid of mark_atom_in_object_info() · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 06/25] cat-file: split expand_atom() into 2 functions · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 16/25] cat-file: move skip_object_info into ref-filter · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 11/25] ref-filter: rename field in ref_array_item stuct · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 04/25] ref-filter: make valid_atom as function parameter · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 03/25] cat-file: reuse struct ref_format · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 25/25] cat-file: update of docs · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 24/25] cat-file: tests for new atoms added · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 15/25] ref_filter: add is_atom_used function · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 10/25] ref-filter: make populate_value() global · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 18/25] ref-filter: make valid_atom general again · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 02/25] ref-filter: add return value to some functions · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 20/25] ref-filter: make populate_value() internal again · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 19/25] cat-file: reuse printing logic from ref-filter · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 12/25] cat-file: start reusing populate_value() · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 14/25] ref-filter: add is_cat flag · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 21/25] ref-filter: unifying formatting of cat-file opts · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 09/25] cat-file: start use ref_array_item struct · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 17/25] ref-filter: make cat_file_info independent · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 23/25] for-each-ref: tests for new atoms added · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH RFC v2 07/25] cat-file: start migrating formatting to ref-filter · Olga Telezhnaya <hidden> · 2018-02-05
[PATCH v3 01/23] ref-filter: get rid of goto · Olga Telezhnaya <hidden> · 2018-02-12
[PATCH v3 03/23] cat-file: reuse struct ref_format · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 03/23] cat-file: reuse struct ref_format · Jeff King <hidden> · 2018-02-15
[PATCH v3 08/23] ref-filter: reuse parse_ref_filter_atom() · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 08/23] ref-filter: reuse parse_ref_filter_atom() · Jeff King <hidden> · 2018-02-15
Re: [PATCH v3 08/23] ref-filter: reuse parse_ref_filter_atom() · Оля Тележная <hidden> · 2018-02-15
[PATCH v3 04/23] ref-filter: make valid_atom as function parameter · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 04/23] ref-filter: make valid_atom as function parameter · Jeff King <hidden> · 2018-02-15
Re: [PATCH v3 04/23] ref-filter: make valid_atom as function parameter · Оля Тележная <hidden> · 2018-02-15
[PATCH v3 11/23] ref-filter: rename field in ref_array_item stuct · Olga Telezhnaya <hidden> · 2018-02-12
[PATCH v3 07/23] cat-file: start migrating formatting to ref-filter · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 07/23] cat-file: start migrating formatting to ref-filter · Jeff King <hidden> · 2018-02-15
[PATCH v3 19/23] ref-filter: make populate_value() internal again · Olga Telezhnaya <hidden> · 2018-02-12
[PATCH v3 16/23] ref-filter: make cat_file_info independent · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 16/23] ref-filter: make cat_file_info independent · Jeff King <hidden> · 2018-02-15
Re: [PATCH v3 16/23] ref-filter: make cat_file_info independent · Оля Тележная <hidden> · 2018-02-15
Re: [PATCH v3 16/23] ref-filter: make cat_file_info independent · Jeff King <hidden> · 2018-02-16
[PATCH v3 20/23] ref-filter: unifying formatting of cat-file opts · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 20/23] ref-filter: unifying formatting of cat-file opts · Jeff King <hidden> · 2018-02-15
Re: [PATCH v3 20/23] ref-filter: unifying formatting of cat-file opts · Оля Тележная <hidden> · 2018-02-15
[PATCH v3 10/23] ref-filter: make populate_value() global · Olga Telezhnaya <hidden> · 2018-02-12
[PATCH v3 15/23] cat-file: move skip_object_info into ref-filter · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 15/23] cat-file: move skip_object_info into ref-filter · Jeff King <hidden> · 2018-02-15
Re: [PATCH v3 15/23] cat-file: move skip_object_info into ref-filter · Оля Тележная <hidden> · 2018-02-15
[PATCH v3 21/23] for-each-ref: tests for new atoms added · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 21/23] for-each-ref: tests for new atoms added · Jeff King <hidden> · 2018-02-15
Re: [PATCH v3 21/23] for-each-ref: tests for new atoms added · Оля Тележная <hidden> · 2018-02-15
[PATCH v3 02/23] ref-filter: add return value to some functions · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 02/23] ref-filter: add return value to some functions · Jeff King <hidden> · 2018-02-15
Re: [PATCH v3 02/23] ref-filter: add return value to some functions · Оля Тележная <hidden> · 2018-02-15
[PATCH v3 09/23] cat-file: start use ref_array_item struct · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 09/23] cat-file: start use ref_array_item struct · Jeff King <hidden> · 2018-02-15
Re: [PATCH v3 09/23] cat-file: start use ref_array_item struct · Оля Тележная <hidden> · 2018-02-15
[PATCH v3 18/23] cat-file: reuse printing logic from ref-filter · Olga Telezhnaya <hidden> · 2018-02-12
[PATCH v3 05/23] cat-file: move struct expand_data into ref-filter · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 05/23] cat-file: move struct expand_data into ref-filter · Jeff King <hidden> · 2018-02-15
[PATCH v3 23/23] cat-file: update of docs · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 23/23] cat-file: update of docs · Jeff King <hidden> · 2018-02-15
[PATCH v3 12/23] cat-file: start reusing populate_value() · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 12/23] cat-file: start reusing populate_value() · Jeff King <hidden> · 2018-02-15
[PATCH v3 14/23] ref_filter: add is_atom_used function · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 14/23] ref_filter: add is_atom_used function · Jeff King <hidden> · 2018-02-15
Re: [PATCH v3 14/23] ref_filter: add is_atom_used function · Оля Тележная <hidden> · 2018-02-15
[PATCH v3 17/23] ref-filter: make valid_atom general again · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 17/23] ref-filter: make valid_atom general again · Jeff King <hidden> · 2018-02-15
[PATCH v3 13/23] ref-filter: get rid of mark_atom_in_object_info() · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 13/23] ref-filter: get rid of mark_atom_in_object_info() · Jeff King <hidden> · 2018-02-15
Re: [PATCH v3 13/23] ref-filter: get rid of mark_atom_in_object_info() · Оля Тележная <hidden> · 2018-02-15
[PATCH v3 22/23] cat-file: tests for new atoms added · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 22/23] cat-file: tests for new atoms added · Adam Dinwoodie <hidden> · 2018-02-16
Re: [PATCH v3 22/23] cat-file: tests for new atoms added · Ramsay Jones <hidden> · 2018-02-18
Re: [PATCH v3 22/23] cat-file: tests for new atoms added · Ramsay Jones <hidden> · 2018-02-19
[PATCH v3 06/23] cat-file: split expand_atom() into 2 functions · Olga Telezhnaya <hidden> · 2018-02-12
Re: [PATCH v3 06/23] cat-file: split expand_atom() into 2 functions · Jeff King <hidden> · 2018-02-15
Re: [PATCH v3 01/23] ref-filter: get rid of goto · Jeff King <hidden> · 2018-02-15

From: Jeff King <hidden>
Date: 2018-02-15 05:08:57

On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote:

Get rid of goto command in ref-filter for better readability.

Signed-off-by: Olga Telezhnaia <redacted>
Mentored-by: Christian Couder [off-list ref]
Mentored by: Jeff King [off-list ref]

OK, makes sense, and the patch looks correct.

-Peff

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help