Re: [PATCH v2 04/21] read-cache: add and then use tweak_split_index()

On Mon, Dec 19, 2016 at 12:18 PM, Duy Nguyen [off-list ref] wrote:

On Sat, Dec 17, 2016 at 03:55:30PM +0100, Christian Couder wrote:

quoted

+static void tweak_split_index(struct index_state *istate)
+{
+     switch (git_config_get_split_index()) {
+     case -1: /* unset: do nothing */
+             break;
+     case 0: /* false */
+             remove_split_index(istate);
+             break;
+     case 1: /* true */
+             add_split_index(istate);
+             break;
+     default: /* unknown value: do nothing */

Probably should die("BUG:") here since it looks to me like
git_config_maybe_bool() (inside git_config_get_split_index) in this
case has been updated to return more values than we can handle. And we
need to know about that so we can handle it properly.

If we later add another value to the possible ones, like for example
"auto", we might not want old versions of Git to fail with a "BUG:..."
message when they read config files tweaked for newer Git versions, so
I don't think we should die() here.

A warning would be ok, but given that in tweak_untracked_cache() we
decided to do nothing, I am thinking that it would be more consistent
to just do nothing here too.