Re: [PATCH v2 02/21] config: add git_config_get_split_index()

On Mon, Dec 19, 2016 at 12:14 PM, Duy Nguyen [off-list ref] wrote:

On Sat, Dec 17, 2016 at 03:55:28PM +0100, Christian Couder wrote:

quoted

diff --git a/config.c b/config.c
index 2eaf8ad77a..c1343bbb3e 100644
--- a/config.c
+++ b/config.c

@@ -1709,6 +1709,16 @@ int git_config_get_untracked_cache(void)
      return -1; /* default value */
 }

+int git_config_get_split_index(void)
+{
+     int val = -1;

Is it redundant to set default value here because it's not used
anywhere? The "return val;" will always have the new value from
git_config_. And you don't use "val" in error case.

Yeah, it is redundant, so I will not set the default value here in the
next version.