Re: [PATCH v2 04/21] read-cache: add and then use tweak_split_index()
From: Duy Nguyen <hidden>
Date: 2016-12-19 11:19:48
On Sat, Dec 17, 2016 at 03:55:30PM +0100, Christian Couder wrote:
+static void tweak_split_index(struct index_state *istate)
+{
+ switch (git_config_get_split_index()) {
+ case -1: /* unset: do nothing */
+ break;
+ case 0: /* false */
+ remove_split_index(istate);
+ break;
+ case 1: /* true */
+ add_split_index(istate);
+ break;
+ default: /* unknown value: do nothing */
Probably should die("BUG:") here since it looks to me like
git_config_maybe_bool() (inside git_config_get_split_index) in this
case has been updated to return more values than we can handle. And we
need to know about that so we can handle it properly.
+ break; + } +}