Thread (134 messages) flat view 134 messages, 4 authors, 2016-06-15

Re: [PATCH v8 32/44] refs.c: remove the update_ref_write function

From: Jonathan Nieder <hidden>
Date: 2016-06-15 23:01:17

Ronnie Sahlberg wrote:
quoted hunk ↗ jump to hunk
+++ b/refs.c
[...]
quoted hunk ↗ jump to hunk
@@ -3518,14 +3499,16 @@ int ref_transaction_commit(struct ref_transaction *transaction,
 		struct ref_update *update = updates[i];
 
 		if (!is_null_sha1(update->new_sha1)) {
-			ret = update_ref_write(msg,
-					       update->refname,
-					       update->new_sha1,
-					       update->lock, err,
-					       UPDATE_REFS_QUIET_ON_ERR);
+			ret = write_ref_sha1(update->lock, update->new_sha1,
+					     msg);
This changes the return value on error from 1 to -1.  That seems like a
good change.  It's probably worth mentioning in the commit message.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help