[PATCH v8 00/44] Use ref transactions for all ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 01/44] refs.c: constify the sha arguments for ref_transaction_create|delete|update · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 01/44] refs.c: constify the sha arguments for ref_transaction_create|delete|update · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v8 04/44] refs.c: add an err argument to repack_without_refs · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 04/44] refs.c: add an err argument to repack_without_refs · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 04/44] refs.c: add an err argument to repack_without_refs · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 28/44] refs.c: make write_ref_sha1 static · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 28/44] refs.c: make write_ref_sha1 static · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 28/44] refs.c: make write_ref_sha1 static · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 25/44] receive-pack.c: use a reference transaction for updating the refs · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 25/44] receive-pack.c: use a reference transaction for updating the refs · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 25/44] receive-pack.c: use a reference transaction for updating the refs · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 25/44] receive-pack.c: use a reference transaction for updating the refs · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 11/44] refs.c: change ref_transaction_create to do error checking and return status · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 11/44] refs.c: change ref_transaction_create to do error checking and return status · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 11/44] refs.c: change ref_transaction_create to do error checking and return status · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 20/44] refs.c: free the transaction before returning when number of updates is 0 · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 29/44] refs.c: make lock_ref_sha1 static · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 29/44] refs.c: make lock_ref_sha1 static · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v8 24/44] fetch.c: use a single ref transaction for all ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 24/44] fetch.c: use a single ref transaction for all ref updates · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 24/44] fetch.c: use a single ref transaction for all ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 21/44] refs.c: ref_transaction_commit should not free the transaction · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 21/44] refs.c: ref_transaction_commit should not free the transaction · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 21/44] refs.c: ref_transaction_commit should not free the transaction · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 21/44] refs.c: ref_transaction_commit should not free the transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 16/44] sequencer.c: use ref transactions for all ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 16/44] sequencer.c: use ref transactions for all ref updates · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v8 17/44] fast-import.c: change update_branch to use ref transactions · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 17/44] fast-import.c: change update_branch to use ref transactions · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 17/44] fast-import.c: change update_branch to use ref transactions · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 22/44] fetch.c: clear errno before calling functions that might set it · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 22/44] fetch.c: clear errno before calling functions that might set it · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 22/44] fetch.c: clear errno before calling functions that might set it · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 22/44] fetch.c: clear errno before calling functions that might set it · Jeff King <hidden> · 2016-06-15
[PATCH v8 31/44] refs.c: remove the update_ref_lock function · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 31/44] refs.c: remove the update_ref_lock function · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v8 26/44] fast-import.c: use a ref transaction when dumping tags · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 26/44] fast-import.c: use a ref transaction when dumping tags · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 26/44] fast-import.c: use a ref transaction when dumping tags · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 42/44] refs.c: pass a skip list to name_conflict_fn · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 42/44] refs.c: pass a skip list to name_conflict_fn · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 42/44] refs.c: pass a skip list to name_conflict_fn · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 36/44] refs.c: pass the ref log message to _create/delete/update instead of _commit · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 36/44] refs.c: pass the ref log message to _create/delete/update instead of _commit · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 36/44] refs.c: pass the ref log message to _create/delete/update instead of _commit · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 35/44] refs.c: make delete_ref use a transaction · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 35/44] refs.c: make delete_ref use a transaction · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 35/44] refs.c: make delete_ref use a transaction · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 35/44] refs.c: make delete_ref use a transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 14/44] replace.c: use the ref transaction functions for updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 14/44] replace.c: use the ref transaction functions for updates · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 14/44] replace.c: use the ref transaction functions for updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 34/44] refs.c: make prune_ref use a transaction to delete the ref · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 34/44] refs.c: make prune_ref use a transaction to delete the ref · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 34/44] refs.c: make prune_ref use a transaction to delete the ref · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 40/44] refs.c: call lock_ref_sha1_basic directly from commit · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 40/44] refs.c: call lock_ref_sha1_basic directly from commit · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v8 44/44] refs.c: remove forward declaration of write_ref_sha1 · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 38/44] refs.c: pack all refs before we start to rename a ref · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 38/44] refs.c: pack all refs before we start to rename a ref · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 38/44] refs.c: pack all refs before we start to rename a ref · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 38/44] refs.c: pack all refs before we start to rename a ref · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 38/44] refs.c: pack all refs before we start to rename a ref · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 43/44] refs.c: make rename_ref use a transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 41/44] refs.c: add a new flag for transaction delete for refs we know are packed only · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 41/44] refs.c: add a new flag for transaction delete for refs we know are packed only · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 41/44] refs.c: add a new flag for transaction delete for refs we know are packed only · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 41/44] refs.c: add a new flag for transaction delete for refs we know are packed only · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 41/44] refs.c: add a new flag for transaction delete for refs we know are packed only · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 41/44] refs.c: add a new flag for transaction delete for refs we know are packed only · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 41/44] refs.c: add a new flag for transaction delete for refs we know are packed only · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 41/44] refs.c: add a new flag for transaction delete for refs we know are packed only · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 41/44] refs.c: add a new flag for transaction delete for refs we know are packed only · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v8 41/44] refs.c: add a new flag for transaction delete for refs we know are packed only · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 41/44] refs.c: add a new flag for transaction delete for refs we know are packed only · Michael Haggerty <hidden> · 2016-06-15
[PATCH v8 37/44] refs.c: pass NULL as *flags to read_ref_full · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 37/44] refs.c: pass NULL as *flags to read_ref_full · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v8 39/44] refs.c: move the check for valid refname to lock_ref_sha1_basic · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 39/44] refs.c: move the check for valid refname to lock_ref_sha1_basic · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 39/44] refs.c: move the check for valid refname to lock_ref_sha1_basic · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 39/44] refs.c: move the check for valid refname to lock_ref_sha1_basic · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 39/44] refs.c: move the check for valid refname to lock_ref_sha1_basic · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 19/44] refs.c: change update_ref to use a transaction · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 19/44] refs.c: change update_ref to use a transaction · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v8 27/44] walker.c: use ref transaction for ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 27/44] walker.c: use ref transaction for ref updates · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 27/44] walker.c: use ref transaction for ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 33/44] refs.c: remove lock_ref_sha1 · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 33/44] refs.c: remove lock_ref_sha1 · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v8 32/44] refs.c: remove the update_ref_write function · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 32/44] refs.c: remove the update_ref_write function · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 32/44] refs.c: remove the update_ref_write function · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 23/44] fetch.c: change s_update_ref to use a ref transaction · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 23/44] fetch.c: change s_update_ref to use a ref transaction · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 23/44] fetch.c: change s_update_ref to use a ref transaction · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 23/44] fetch.c: change s_update_ref to use a ref transaction · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 23/44] fetch.c: change s_update_ref to use a ref transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 15/44] commit.c: use ref transactions for updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 15/44] commit.c: use ref transactions for updates · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v8 30/44] refs.c: add transaction.status and track OPEN/CLOSED/ERROR · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 30/44] refs.c: add transaction.status and track OPEN/CLOSED/ERROR · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 30/44] refs.c: add transaction.status and track OPEN/CLOSED/ERROR · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 30/44] refs.c: add transaction.status and track OPEN/CLOSED/ERROR · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 30/44] refs.c: add transaction.status and track OPEN/CLOSED/ERROR · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 03/44] refs.c: add a strbuf argument to ref_transaction_commit for error logging · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 10/44] refs.c: change ref_transaction_update() to do error checking and return status · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 10/44] refs.c: change ref_transaction_update() to do error checking and return status · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 10/44] refs.c: change ref_transaction_update() to do error checking and return status · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 18/44] branch.c: use ref transaction for all ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 18/44] branch.c: use ref transaction for all ref updates · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v8 12/44] refs.c: ref_transaction_delete to check for error and return status · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 12/44] refs.c: ref_transaction_delete to check for error and return status · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 12/44] refs.c: ref_transaction_delete to check for error and return status · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 07/44] refs.c: make update_ref_write update a strbuf on failure · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 13/44] tag.c: use ref transactions when doing updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 13/44] tag.c: use ref transactions when doing updates · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 13/44] tag.c: use ref transactions when doing updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 05/44] refs.c: make ref_update_reject_duplicates take a strbuf argument for errors · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 09/44] refs.c: remove the onerr argument to ref_transaction_commit · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 06/44] refs.c: add an err argument ro delete_loose_ref · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 06/44] refs.c: add an err argument ro delete_loose_ref · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 06/44] refs.c: add an err argument ro delete_loose_ref · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v8 08/44] update-ref.c: log transaction error from the update_ref · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 08/44] update-ref.c: log transaction error from the update_ref · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v8 02/44] refs.c: allow passing NULL to ref_transaction_free · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 02/44] refs.c: allow passing NULL to ref_transaction_free · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 02/44] refs.c: allow passing NULL to ref_transaction_free · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v8 00/44] Use ref transactions for all ref updates · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 00/44] Use ref transactions for all ref updates · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 00/44] Use ref transactions for all ref updates · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 00/44] Use ref transactions for all ref updates · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 00/44] Use ref transactions for all ref updates · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v8 00/44] Use ref transactions for all ref updates · Ronnie Sahlberg <hidden> · 2016-06-15

Re: [PATCH v8 11/44] refs.c: change ref_transaction_create to do error checking and return status

From: Jonathan Nieder <hidden>
Date: 2016-06-15 23:01:11

Ronnie Sahlberg wrote:

Do basic error checking in ref_transaction_create() and make it return
non-zero on error.

Same thoughts as _update().  Basic idea is good but would be nice to
have a 'struct strbuf *err' parameter.

Thanks,
Jonathan

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help