Thread (134 messages) flat view 134 messages, 4 authors, 2016-06-15

Re: [PATCH v8 21/44] refs.c: ref_transaction_commit should not free the transaction

From: Jonathan Nieder <hidden>
Date: 2016-06-15 23:01:11

Ronnie Sahlberg wrote:
Change ref_transaction_commit so that it does not free the transaction.
Instead require that a caller will end a transaction by either calling
ref_transaction_rollback or ref_transaction_free.
Can I always use ref_transaction_rollback instead of ref_transaction_free?
It would be convenient if my cleanup code could always call _rollback
instead of having to do something different for success and errors.

Another way to ask the question: what is it valid to do with a
transaction after commiting?

Thanks,
Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help