Thread (64 messages) flat view 64 messages, 2 authors, 2016-06-15

Re: [PATCH 2/8] revert: decouple sequencer actions from builtin commands

From: Ramkumar Ramachandra <hidden>
Date: 2016-06-15 22:52:46

Jonathan Nieder wrote:
Honestly, moving code verbatim between files is very easy.  Repeatedly
rebasing a patch that carries out such a move would presumably be
hard, though.  But this pain is unnecessary!

Just like I haven't been reviewing the code movement, I'd be perfectly
happy to read a "patch" that says

       "And then we move the functions from the following list to
       sequencer.c.  I'll send a patch doing so once work has settled
       down in patches earlier in this series."
More than the pain of rebasing the patch everytime, I guess what I'm
asking is: is it worth stretching my foresight like this?  Once the
code is in sequencer.c, it just becomes so much easier for me to write
scratch code to help me wrap my head around the generalization.  If
the answer to the question is yes, I suppose it makes sense to submit
the good parts now and work on the other parts over an extended period
of time.

-- Ram
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help