On Wed, 13 Oct 2021 15:03:56 +0000
"Ananyev, Konstantin" [off-list ref] wrote:

quoted

addr value' can be before other operations.
  

quoted

BTW, if we expect memorder to always be a constant, might be better
BUILD_BUG_ON()?  

If I understand correctly, you means we can replace 'assert' by 'build_bug_on':
RTE_BUILD_BUG_ON(memorder != __ATOMIC_ACQUIRE && memorder !=__ATOMIC_RELAXED);  

Yes, that was my thought.
In that case I think we should be able to catch wrong memorder at compilation stage.

Maybe:
   RTE_BUILD_BUG_ON(!_constant_p(memorder));
   RTE_BUILD_BUG_ON(memorder != __ATOMIC_ACQUIRE && memorder !=__ATOMIC_RELAXED);