[dpdk-dev] [RFC PATCH v1 3/5] eal: use wait until scheme for mcslock
From: Feifei Wang <hidden>
Date: 2021-09-02 05:33:28
Subsystem:
library code, the rest · Maintainers:
Andrew Morton, Linus Torvalds
From: Feifei Wang <hidden>
Date: 2021-09-02 05:33:28
Subsystem:
library code, the rest · Maintainers:
Andrew Morton, Linus Torvalds
Instead of polling for mcslock to be updated, use wait_until_unequal for this case. Signed-off-by: Feifei Wang <redacted> Reviewed-by: Ruifeng Wang <redacted> --- lib/eal/include/generic/rte_mcslock.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/lib/eal/include/generic/rte_mcslock.h b/lib/eal/include/generic/rte_mcslock.h
index 9f323bd2a2..dabad0d4e0 100644
--- a/lib/eal/include/generic/rte_mcslock.h
+++ b/lib/eal/include/generic/rte_mcslock.h@@ -117,8 +117,13 @@ rte_mcslock_unlock(rte_mcslock_t **msl, rte_mcslock_t *me) /* More nodes added to the queue by other CPUs. * Wait until the next pointer is set. */ - while (__atomic_load_n(&me->next, __ATOMIC_RELAXED) == NULL) - rte_pause(); +#ifdef RTE_ARCH_32 + rte_wait_until_unequal_32((volatile uint32_t *)&me->next, + 0, __ATOMIC_RELAXED); +#else + rte_wait_until_unequal_64((volatile uint64_t *)&me->next, + 0, __ATOMIC_RELAXED); +#endif } /* Pass lock to next waiter. */
--
2.25.1