Re: [dpdk-dev] [v5] telemetry: fix json output buffer size

29/09/2021 06:18, Gowrishankar Muthukrishnan:

Fix json output buffer size for an actual data length.

Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON")

Please could you give a bit more explanations?
What was not working and why?

[...]

- * This function is not for use for values larger than 1k.
+ * This function is not for use for values larger than given buffer length.
  */
 __rte_format_printf(3, 4)
 static inline int
 __json_snprintf(char *buf, const int len, const char *format, ...)
 {
-	char tmp[1024];
+	char tmp[len];
 	va_list ap;
 	int ret;