[dpdk-dev] [v4] telemetry: fix json output buffer size
From: Gowrishankar Muthukrishnan <hidden>
Date: 2021-09-23 06:26:32
Subsystem:
library code, the rest · Maintainers:
Andrew Morton, Linus Torvalds
Fix json output buffer size for a single largest value.
Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON")
Signed-off-by: Gowrishankar Muthukrishnan <redacted>
---
v4:
- corrected typo in commit message.
v3:
- use "len" param as buffer size.
---
lib/telemetry/telemetry_json.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/telemetry/telemetry_json.h b/lib/telemetry/telemetry_json.h
index ad270b9b30..f02a12f5b0 100644
--- a/lib/telemetry/telemetry_json.h
+++ b/lib/telemetry/telemetry_json.h@@ -9,6 +9,7 @@ #include <stdarg.h> #include <stdio.h> #include <rte_common.h> +#include <rte_telemetry.h> /** * @file
@@ -23,13 +24,13 @@ * @internal * Copies a value into a buffer if the buffer has enough available space. * Nothing written to buffer if an overflow ocurs. - * This function is not for use for values larger than 1k. + * This function is not for use for values larger than given buffer length. */ __rte_format_printf(3, 4) static inline int __json_snprintf(char *buf, const int len, const char *format, ...) { - char tmp[1024]; + char tmp[len]; va_list ap; int ret;
--
2.25.1