Thread (121 messages) flat view 121 messages, 10 authors, 2021-11-04

Re: [dpdk-dev] [EXT] Re: [v4, 1/2] common/cnxk: add telemetry endpoints to npa

From: Gowrishankar Muthukrishnan <hidden>
Date: 2021-08-27 06:43:52

quoted
 includes += include_directories('../../bus/pci')
 includes += include_directories('../../../lib/net')
+includes += include_directories('../../../lib/telemetry')
Rather than giving the include directories, I'd recommend using "deps"
variable to specify a direct dependency on those libraries. This should probably
be:

deps += ['bus_pci', 'net', 'telemetry']

Using these as dependencies means that the header paths will be added
automatically, and the libraries linked against too if any functions from those
are used by the code in this lib.
Ack. Thanks Bruce.

Regards,
Gowrishankar
Regards,
/Bruce
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help