Re: [dpdk-dev] [v3, 0/3] common/cnxk: enable npa telemetry
From: Gowrishankar Muthukrishnan <hidden>
Date: 2021-08-24 08:53:48
Hi, Please let me know if any other info is required. Thanks, Gowrishankar
-----Original Message----- From: dev <redacted> On Behalf Of Gowrishankar Muthukrishnan Sent: Wednesday, August 11, 2021 9:49 PM To: Power, Ciara <redacted>; dev@dpdk.org Cc: Richardson, Bruce <redacted>; Jerin Jacob Kollanukkaran [off-list ref]; Kiran Kumar Kokkilagadda [off-list ref]; Nithin Kumar Dabilpuram [off-list ref]; Sunil Kumar Kori [off-list ref]; Satha Koteswara Rao Kottidi [off-list ref] Subject: [EXT] Re: [dpdk-dev] [v3, 0/3] common/cnxk: enable npa telemetry External Email ---------------------------------------------------------------------- Hi Ciara,quoted
-----Original Message----- From: Power, Ciara <redacted> Sent: Wednesday, August 11, 2021 9:30 PM To: Gowrishankar Muthukrishnan <redacted>; dev@dpdk.org Cc: Richardson, Bruce <redacted>; Jerin Jacob Kollanukkaran [off-list ref]; Kiran Kumar Kokkilagadda [off-list ref]; Nithin Kumar Dabilpuram [off-list ref]; Sunil Kumar Kori [off-list ref]; Satha Koteswara Rao Kottidi [off-list ref] Subject: [EXT] RE: [v3, 0/3] common/cnxk: enable npa telemetry External Email ---------------------------------------------------------------------- Hi Gowrishankar,quoted
-----Original Message----- From: Gowrishankar Muthukrishnan <redacted> Sent: Tuesday 3 August 2021 09:06 To: dev@dpdk.org Cc: Richardson, Bruce <redacted>; Power, Ciara [off-list ref]; jerinj@marvell.com; kirankumark@marvell.com; ndabilpuram@marvell.com; skori@marvell.com; skoteshwar@marvell.com; Gowrishankar Muthukrishnan [off-list ref] Subject: [v3, 0/3] common/cnxk: enable npa telemetry This patch series enables telemetry in NPA LF of cnxk. v3: - fixed format specifier for uintptr_t Gowrishankar Muthukrishnan (3): telemetry: enable storing pointer value test/telemetry: add unit tests for pointer value common/cnxk: add telemetry endpoints to npa app/test/test_telemetry_data.c | 125 +++++++++++++ app/test/test_telemetry_json.c | 29 ++- drivers/common/cnxk/cnxk_telemetry.h | 26 +++ drivers/common/cnxk/cnxk_telemetry_npa.c | 227 +++++++++++++++++++++++ drivers/common/cnxk/meson.build | 4 + drivers/common/cnxk/roc_platform.h | 8 + lib/telemetry/rte_telemetry.h | 37 +++- lib/telemetry/telemetry.c | 21 ++- lib/telemetry/telemetry_data.c | 40 +++- lib/telemetry/telemetry_data.h | 2 + lib/telemetry/telemetry_json.h | 32 ++++ lib/telemetry/version.map | 2 + 12 files changed, 539 insertions(+), 14 deletions(-) create mode 100644 drivers/common/cnxk/cnxk_telemetry.h create mode 100644 drivers/common/cnxk/cnxk_telemetry_npa.c -- 2.25.1I am still unsure exactly what the use case is here - why are we choosing to publish the pointer values through telemetry rather than using a debug log for example?Pointer values are useful sometimes for more debugging through telemetry, hence this proposal. As I mentioned in v1 thread, this is architecture compliant approach rather than assuming pointer value is always 64 bit, when there is need to use pointer value in current telemetry path. Thanks, Gowrishankarquoted
Maybe I am missing something here. Thanks, Ciara