Re: [dpdk-dev] [RFC UPDATE PATCH 1/9] dmadev: add missing exports
From: David Marchand <hidden>
Date: 2021-07-07 08:57:45
From: David Marchand <hidden>
Date: 2021-07-07 08:57:45
On Wed, Jul 7, 2021 at 10:37 AM Bruce Richardson [off-list ref] wrote:
On Wed, Jul 07, 2021 at 10:26:36AM +0200, David Marchand wrote:quoted
On Tue, Jul 6, 2021 at 10:29 PM Bruce Richardson [off-list ref] wrote:quoted
Export the rte_dmadevices array and the allocate and release functions which are needed by PMDs.rte_dmadevices[] might be an issue for inline accesses, but pmd allocate/release should be internal (driver only).So if I understand correctly, they still need to be in the version.map
drivers still need them exported, so yes they must be in version.map with INTERNAL version.
file, but with "interal" versioning rather than "experimental", right?
But I would move them too in a separate header, for drivers, like ethdev_driver.h. And the __rte_internal tag will be needed at their declarations. https://git.dpdk.org/dpdk/tree/lib/ethdev/ethdev_driver.h#n1005 https://git.dpdk.org/dpdk/tree/lib/ethdev/version.map#n257 -- David Marchand