On Tue, Jul 06, 2021 at 11:56:03AM +0800, fengchengwen wrote:

Many thanks, mostly OK, a few comment inline

On 2021/7/4 22:57, Andrew Rybchenko wrote:

quoted

On 7/2/21 4:18 PM, Chengwen Feng wrote:

quoted

This patch introduces 'dmadevice' which is a generic type of DMA
device.

<snip>

quoted

Do we really need both stats and xstats from the very
beginning? I think it is better to start from just
generic stats and add xstats when it is really required.

OK, but I think we should add one dump ops, which could be useful to
find the problem.

+1 to both suggestions - dropping xstats (for now) and adding dump fn.