Thread (195 messages) 195 messages, 4 authors, 2021-01-28

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 03/37] net/mvpp2: fix Rx/Tx bytes statistics

From: Ferruh Yigit <hidden>
Date: 2021-01-26 17:02:59

On 1/22/2021 7:18 PM, lironh@marvell.com wrote:
quoted hunk ↗ jump to hunk
From: Yuri Chipchev <redacted>

4B of CRC was not included in the bytes statistics

Fixes: bdffe0c70 ("net/mrvl: support basic stats")
Cc: stable@dpdk.org

Signed-off-by: Yuri Chipchev <redacted>
Reviewed-by: Liron Himi <redacted>
---
  drivers/net/mvpp2/mrvl_ethdev.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c
index bfe496ff7..a1a3c0e31 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -1278,7 +1278,6 @@ mrvl_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
  				       rx_stats.drop_fullq +
  				       rx_stats.drop_bm +
  				       rxq->drop_mac;
-		stats->ibytes += rxq->bytes_recv;
  		drop_mac += rxq->drop_mac;
  	}
  
@@ -1306,7 +1305,6 @@ mrvl_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
  
  		stats->q_opackets[idx] = tx_stats.deq_desc;
  		stats->q_obytes[idx] = txq->bytes_sent;
-		stats->obytes += txq->bytes_sent;
  	}
  
  	ret = pp2_ppio_get_statistics(priv->ppio, &ppio_stats, 0);
@@ -1315,6 +1313,8 @@ mrvl_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
  		return ret;
  	}
  
+	stats->ibytes += ppio_stats.rx_bytes;
+	stats->obytes += ppio_stats.tx_bytes;
  	stats->ipackets += ppio_stats.rx_packets - drop_mac;
  	stats->opackets += ppio_stats.tx_packets;
  	stats->imissed += ppio_stats.rx_fullq_dropped +
Is this patch adding CRC to the stats? If so that is wrong, stats should not 
have the CRC.

A recent clarification from Andrew:
https://patches.dpdk.org/patch/86975/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help