Thread (195 messages) 195 messages, 4 authors, 2021-01-28

Re: [dpdk-dev] [PATCH v1 04/38] net/mvpp2: skip vlan flush

From: Jerin Jacob <hidden>
Date: 2021-01-11 14:38:57

On Wed, Dec 23, 2020 at 3:15 PM Michael Shamis [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Reviewed-by: Michael Shamis <redacted>

-----Original Message-----
From: dev <redacted> On Behalf Of lironh@marvell.com
Sent: Wednesday, December 2, 2020 12:12 PM
To: Jerin Jacob Kollanukkaran <redacted>
Cc: dev@dpdk.org; Liron Himi <redacted>; stable@dpdk.org
Subject: [dpdk-dev] [PATCH v1 04/38] net/mvpp2: skip vlan flush

From: Liron Himi <redacted>

vlan-flush in MUSDK is not supported yet.
until it does, the code should be skipped as currently an redundant  error message is displayed.

Fixes: a8f3d6783 ("net/mrvl: support VLAN filtering")
Cc: stable@dpdk.org

Signed-off-by: Liron Himi <redacted>
Reviewed-by: Liron Himi <redacted>
---
 drivers/net/mvpp2/mrvl_ethdev.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index ebd2bb1c8..0985ccebe 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -672,15 +672,15 @@ mrvl_dev_start(struct rte_eth_dev *dev)
        }

        if (!priv->vlan_flushed) {
-               ret = pp2_ppio_flush_vlan(priv->ppio);
-               if (ret) {
-                       MRVL_LOG(ERR, "Failed to flush vlan list");
-                       /*
-                        * TODO
-                        * once pp2_ppio_flush_vlan() is supported jump to out
-                        * goto out;
-                        */
-               }
+               /*
+                * TODO
+                * once pp2_ppio_flush_vlan() is supported call it
+                * ret = pp2_ppio_flush_vlan(priv->ppio);
+                * if (ret) {
+                *      MRVL_LOG(ERR, "Failed to flush vlan list");
+                *      goto out;
+                * }
+                */
This kind of TODO is no go in upstream code.
I think, MUSDK can be updated to skip the error and have an API detect
the feature
is present or not? so that drivers can make intelligent decisions and
have clean code.


                priv->vlan_flushed = 1;
        }
        ret = mrvl_mtu_set(dev, dev->data->mtu);
--
2.28.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help