Re: [dpdk-dev] [PATCH v1 02/38] net/mvpp2: remove debug log on fast-path
From: Jerin Jacob <hidden>
Date: 2021-01-11 14:33:49
On Wed, Dec 2, 2020 at 3:42 PM [off-list ref] wrote:
From: Liron Himi <redacted> in case of non-ip frame the current code reached the 'default'
In case of
case which result with function call to log a msg.
those kind of calls should not be performed on fast-path.
The performance for this kind of frames increased by 50%
Fixes: acab7d58c ("net/mvpp2: convert to dynamic logging")
Cc: stable@dpdk.org
Signed-off-by: Liron Himi <redacted>
Reviewed-by: Liron Himi <redacted>Please remove the Reviewed-by if you have Signed-off,
quoted hunk ↗ jump to hunk
--- drivers/net/mvpp2/mrvl_ethdev.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index 93fb30cdb..8c3278ec4 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c@@ -2171,7 +2171,6 @@ mrvl_desc_to_packet_type_and_offset(struct pp2_ppio_desc *desc, *l4_offset = *l3_offset + MRVL_ARP_LENGTH; break; default: - MRVL_LOG(DEBUG, "Failed to recognise l3 packet type"); break; }@@ -2183,7 +2182,6 @@ mrvl_desc_to_packet_type_and_offset(struct pp2_ppio_desc *desc, packet_type |= RTE_PTYPE_L4_UDP; break; default: - MRVL_LOG(DEBUG, "Failed to recognise l4 packet type");
There are other prints in fastpath such as "MRVL_LOG(ERR, "Failed to receive packets");", please remove those as well.
break;
}
--
2.28.0