07/01/2021 10:32, Guo, Jia:

From: Thomas Monjalon <redacted>

quoted

24/12/2020 07:59, Jeff Guo:

quoted

Add type of RTE_TUNNEL_TYPE_ECPRI into the enum of ethdev tunnel

type.

quoted

Signed-off-by: Jeff Guo <redacted>
Reviewed-by: Qi Zhang <redacted>

[...]

quoted

--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h

@@ -1219,6 +1219,7 @@ enum rte_eth_tunnel_type {
 	RTE_TUNNEL_TYPE_IP_IN_GRE,
 	RTE_L2_TUNNEL_TYPE_E_TAG,
 	RTE_TUNNEL_TYPE_VXLAN_GPE,
+	RTE_TUNNEL_TYPE_ECPRI,
 	RTE_TUNNEL_TYPE_MAX,
 };

We tried to remove all these legacy API in DPDK 20.11.
Andrew decided to not remove this one because it is not yet completely
replaced by rte_flow in all drivers.
However, I am against continuing to update this API.
The opposite work should be done: migrate to rte_flow.

Agree but seems that the legacy api and driver legacy implementation
still keep in this release, and there is no a general way to replace
the legacy by rte_flow right now.

I think rte_flow is a complete replacement with more features.
You can match, encap, decap.
There is even a new API to get tunnel infos after decap.
What is missing?

quoted

Sorry, it is a nack.
BTW, it is probably breaking the ABI because of RTE_TUNNEL_TYPE_MAX.

Oh, the ABI break should be a problem.

quoted

PS: please Cc ethdev maintainers for such patch, thanks.
tip: use --cc-cmd devtools/get-maintainer.sh

Thanks for your helpful tip.