Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri
From: Thomas Monjalon <hidden>
Date: 2021-01-06 22:12:23
24/12/2020 07:59, Jeff Guo:
Add type of RTE_TUNNEL_TYPE_ECPRI into the enum of ethdev tunnel type. Signed-off-by: Jeff Guo <redacted> Reviewed-by: Qi Zhang <redacted>
[...]
quoted hunk ↗ jump to hunk
--- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h@@ -1219,6 +1219,7 @@ enum rte_eth_tunnel_type { RTE_TUNNEL_TYPE_IP_IN_GRE, RTE_L2_TUNNEL_TYPE_E_TAG, RTE_TUNNEL_TYPE_VXLAN_GPE, + RTE_TUNNEL_TYPE_ECPRI, RTE_TUNNEL_TYPE_MAX, };
We tried to remove all these legacy API in DPDK 20.11. Andrew decided to not remove this one because it is not yet completely replaced by rte_flow in all drivers. However, I am against continuing to update this API. The opposite work should be done: migrate to rte_flow. Sorry, it is a nack. BTW, it is probably breaking the ABI because of RTE_TUNNEL_TYPE_MAX. PS: please Cc ethdev maintainers for such patch, thanks. tip: use --cc-cmd devtools/get-maintainer.sh