-----Original Message-----
From: Thomas Monjalon <redacted>
Sent: Thursday, January 7, 2021 6:12 AM
To: Guo, Jia <redacted>
Cc: Zhang, Qi Z <redacted>; Wu, Jingjing
[off-list ref]; Yang, Qiming [off-list ref]; Wang,
Haiyue [off-list ref]; dev@dpdk.org; Yigit, Ferruh
[off-list ref]; andrew.rybchenko@oktetlabs.ru
Subject: Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for
ecpri

24/12/2020 07:59, Jeff Guo:

quoted

Add type of RTE_TUNNEL_TYPE_ECPRI into the enum of ethdev tunnel

type.

quoted

Signed-off-by: Jeff Guo <redacted>
Reviewed-by: Qi Zhang <redacted>

[...]

quoted

--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h

@@ -1219,6 +1219,7 @@ enum rte_eth_tunnel_type {
 	RTE_TUNNEL_TYPE_IP_IN_GRE,
 	RTE_L2_TUNNEL_TYPE_E_TAG,
 	RTE_TUNNEL_TYPE_VXLAN_GPE,
+	RTE_TUNNEL_TYPE_ECPRI,
 	RTE_TUNNEL_TYPE_MAX,
 };

We tried to remove all these legacy API in DPDK 20.11.
Andrew decided to not remove this one because it is not yet completely
replaced by rte_flow in all drivers.
However, I am against continuing to update this API.
The opposite work should be done: migrate to rte_flow.

Agree but seems that the legacy api and driver legacy implementation still keep in this release, and there is no a general way to replace the legacy by rte_flow right now.

Sorry, it is a nack.
BTW, it is probably breaking the ABI because of RTE_TUNNEL_TYPE_MAX.

Oh, the ABI break should be a problem.

PS: please Cc ethdev maintainers for such patch, thanks.
tip: use --cc-cmd devtools/get-maintainer.sh

Thanks for your helpful tip.