Re: [PATCH 14/15] net/vmxnet3: rename version map after library file name
From: Thomas Monjalon <hidden>
Date: 2018-09-14 07:46:51
13/09/2018 23:44, Yong Wang:
From: Luca Boccassi <redacted>
The library is called librte_pmd_vmxnet3_uio, so rename the map
file and set the name in the meson file so that the built library names
with meson and legacy makefiles are the same
Signed-off-by: Luca Boccassi [off-list ref]
---
Not directly related to this change but I have some question on the uio naming. The original motivation is from the following commit:
commit 1daf0aae7fd6b3bc38952e9817a1653c1258be66
Author: Thomas Monjalon [off-list ref]
Date: Fri Mar 21 13:52:17 2014 +0100
vmxnet3: rename library
In order to distinguish clearly this implementation from the extension
vmxnet3-usermap, it is renamed to reflect its usage of uio framework.
Signed-off-by: Thomas Monjalon [off-list ref]
Acked-by: Thomas Graf [off-list ref]
However, this version of vmxnet3 can also be bound to vfio-pci driver. I think having the uio naming in that case will be misleading. Yes, i agree. vmxnet3-usermap is not maintained anymore, so we can remove the uio suffix.