Re: [PATCH 14/15] net/vmxnet3: rename version map after library file name
From: Yong Wang <hidden>
Date: 2018-09-13 21:44:21
-----Original Message-----
From: Luca Boccassi <redacted>
Date: Monday, September 10, 2018 at 1:05 PM
To: "dev@dpdk.org" <redacted>
Cc: "keith.wiles@intel.com" <redacted>, "roy.fan.zhang@intel.com" <redacted>, "jingjing.wu@intel.com" <redacted>, "wenzhuo.lu@intel.com" <redacted>, "rasesh.mody@cavium.com" <redacted>, "harish.patil@cavium.com" <redacted>, "shahed.shaikh@cavium.com" <redacted>, "amr.mokhtar@intel.com" <redacted>, "shijith.thotton@cavium.com" <redacted>, "ssrinivasan@cavium.com" <redacted>, "liang.j.ma@intel.com" <redacted>, "peter.mccarthy@intel.com" <redacted>, "jerin.jacob@caviumnetworks.com" <redacted>, "maciej.czekaj@caviumnetworks.com" <redacted>, "arybchenko@solarflare.com" <redacted>, "antosh.shukla@caviumnetworks.com" <redacted>, "ashish.gupta@cavium.com" <redacted>, Yong Wang <redacted>, "bruce.richardson@intel.com" <redacted>, "thomas@monjalon.net" <redacted>
Subject: [PATCH 14/15] net/vmxnet3: rename version map after library file name
The library is called librte_pmd_vmxnet3_uio, so rename the map
file and set the name in the meson file so that the built library names
with meson and legacy makefiles are the same
Signed-off-by: Luca Boccassi [off-list ref]
---
Not directly related to this change but I have some question on the uio naming. The original motivation is from the following commit:
commit 1daf0aae7fd6b3bc38952e9817a1653c1258be66
Author: Thomas Monjalon [off-list ref]
Date: Fri Mar 21 13:52:17 2014 +0100
vmxnet3: rename library
In order to distinguish clearly this implementation from the extension
vmxnet3-usermap, it is renamed to reflect its usage of uio framework.
Signed-off-by: Thomas Monjalon [off-list ref]
Acked-by: Thomas Graf [off-list ref]
However, this version of vmxnet3 can also be bound to vfio-pci driver. I think having the uio naming in that case will be misleading.
drivers/net/vmxnet3/Makefile | 2 +-
..._pmd_vmxnet3_version.map => rte_pmd_vmxnet3_uio_version.map} | 0
2 files changed, 1 insertion(+), 1 deletion(-)
rename drivers/net/vmxnet3/{rte_pmd_vmxnet3_version.map => rte_pmd_vmxnet3_uio_version.map} (100%)
diff --git a/drivers/net/vmxnet3/Makefile b/drivers/net/vmxnet3/Makefile
index f1141da674..9848cd224f 100644
--- a/drivers/net/vmxnet3/Makefile
+++ b/drivers/net/vmxnet3/Makefile
@@ -43,7 +43,7 @@ LDLIBS += -lrte_bus_pci
VPATH += $(SRCDIR)/base
-EXPORT_MAP := rte_pmd_vmxnet3_version.map
+EXPORT_MAP := rte_pmd_vmxnet3_uio_version.map
LIBABIVER := 1
diff --git a/drivers/net/vmxnet3/rte_pmd_vmxnet3_version.map b/drivers/net/vmxnet3/rte_pmd_vmxnet3_uio_version.map
similarity index 100%
rename from drivers/net/vmxnet3/rte_pmd_vmxnet3_version.map
rename to drivers/net/vmxnet3/rte_pmd_vmxnet3_uio_version.map
--
2.18.0