Re: [PATCH 07/15] net/liquidio: rename version map after library file name
From: Luca Boccassi <hidden>
Date: 2018-09-11 13:41:39
On Tue, 2018-09-11 at 14:32 +0100, Bruce Richardson wrote:
On Tue, Sep 11, 2018 at 02:09:30PM +0100, Luca Boccassi wrote:quoted
On Tue, 2018-09-11 at 14:06 +0100, Bruce Richardson wrote:quoted
On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi wrote:quoted
The library is called librte_pmd_lio, so rename the map file and set the name in the meson file so that the built library names with meson and legacy makefiles are the same Fixes: bad475c03fee ("net/liquidio: add to meson build") Cc: stable@dpdk.org Signed-off-by: Luca Boccassi <redacted>Rather than doing this renaming, can we instead add a symlink in the install phase to map the old name to the new one? I'd like to see the consistency of directory name, map filename and driver name enforced strictly in the build system. Having exceptions is a pain. /BruceWe could, but the pain gets shifted on packagers then - what about renaming the directory entirely to net/lio?For packagers, what sort of ABI compatibility guarantees do you try and keep between releases. Is this something that just needs a one- release ABI announcement, as with other ABI changes? /Bruce
Currently in Debian/Ubuntu we are using the ABI override (because of the sticky ABI breakage issue) so the filenames and package names are different on every release anyway. So in theory we could change the name of the libs and packages, but what I'm mostly worried about is keeping consistency and some level of compatibility between old and new build systems, isn't that an issue? -- Kind regards, Luca Boccassi