Re: [PATCH 07/15] net/liquidio: rename version map after library file name

On Tue, 2018-09-11 at 15:06 +0100, Bruce Richardson wrote:

On Tue, Sep 11, 2018 at 02:41:36PM +0100, Luca Boccassi wrote:

quoted

On Tue, 2018-09-11 at 14:32 +0100, Bruce Richardson wrote:

quoted

On Tue, Sep 11, 2018 at 02:09:30PM +0100, Luca Boccassi wrote:

quoted

On Tue, 2018-09-11 at 14:06 +0100, Bruce Richardson wrote:

quoted

On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi
wrote:

quoted

The library is called librte_pmd_lio, so rename the map
file
and
set
the name in the meson file so that the built library names
with
meson
and legacy makefiles are the same

Fixes: bad475c03fee ("net/liquidio: add to meson build")
Cc: stable@dpdk.org

Signed-off-by: Luca Boccassi <redacted>

Rather than doing this renaming, can we instead add a symlink
in
the
install phase to map the old name to the new one? I'd like to
see
the
consistency of directory name, map filename and driver name
enforced
strictly in the build system. Having exceptions is a pain.

/Bruce

We could, but the pain gets shifted on packagers then - what
about
renaming the directory entirely to net/lio?

For packagers, what sort of ABI compatibility guarantees do you
try
and
keep between releases. Is this something that just needs a one-
release ABI
announcement, as with other ABI changes?

/Bruce

Currently in Debian/Ubuntu we are using the ABI override (because
of
the sticky ABI breakage issue) so the filenames and package names
are
different on every release anyway.

So in theory we could change the name of the libs and packages, but
what I'm mostly worried about is keeping consistency and some level
of
compatibility between old and new build systems, isn't that an
issue?

It's a good question, and I suspect everyone will have their own
opinion.

Personally, I take the view that moving build system involves quite a
number of changes anyway, so we should take the opportunity to clean
up a
few other things at the same time. This is why I'm so keep on trying
to
keep everything consistent as far as possible throughout the system
and not
put in special cases. For many of these a) if we put in lots of name
overrides now we'll probably never get rid of them, and b) it's more
likely
that future drivers will adopt the same technique to have different
naming
of drivers and directories.

However, if keeping sonames consistent is a major concern, then
perhaps we
should look to rename some directories, like you suggested before.

/Bruce

Actually I tend to agree, it would be better to make the libraries
consistent, so I'm fine with having to deal with it once in packaging.
I'll send a v2 without most of the renames.

-- 
Kind regards,
Luca Boccassi